[
https://issues.apache.org/jira/browse/BEAM-9187?focusedWorklogId=518261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518261
]
ASF GitHub Bot logged work on BEAM-9187:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/20 03:23
Start Date: 01/Dec/20 03:23
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13448:
URL: https://github.com/apache/beam/pull/13448#discussion_r533048304
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactoryTest.java
##########
@@ -459,27 +461,28 @@ public void loadBalancesBundles() throws Exception {
verify(envFactory, Mockito.times(2)).createEnvironment(eq(environment),
any());
long tms = System.currentTimeMillis();
- AtomicBoolean closed = new AtomicBoolean();
- // close to free up environment for another bundle
- TimerTask closeBundleTask =
- new TimerTask() {
- @Override
- public void run() {
- try {
- b2.close();
- closed.set(true);
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
- }
- };
- new Timer().schedule(closeBundleTask, 100);
-
+ ScheduledExecutorService executor =
Executors.newSingleThreadScheduledExecutor();
+ ScheduledFuture<Optional<Exception>> closingFuture =
+ executor.schedule(
+ () -> {
+ try {
+ b2.close();
+ return Optional.empty();
+ } catch (Exception e) {
Review comment:
Hm could it be that Future only does that for unchecked exceptions? I
had tried just making this `executor.schedule(b2::close, ..)` but it produces a
compile error:
```
incompatible thrown types Exception in method reference
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518261)
Time Spent: 0.5h (was: 20m)
> org.apache.beam.runners.fnexecution.control.DefaultJobBundleFactoryTest.loadBalancesBundles
> is flaky
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-9187
> URL: https://issues.apache.org/jira/browse/BEAM-9187
> Project: Beam
> Issue Type: Test
> Components: runner-core
> Reporter: Etienne Chauchot
> Assignee: Brian Hulette
> Priority: P1
> Labels: flake, flaky-test
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [org.apache.beam.runners.fnexecution.control.DefaultJobBundleFactoryTest.loadBalancesBundles|https://builds.apache.org/job/beam_PreCommit_Java_Commit/9730/testReport/junit/org.apache.beam.runners.fnexecution.control/DefaultJobBundleFactoryTest/loadBalancesBundles/]
> UTest seem to be flaky:
> [https://builds.apache.org/job/beam_PreCommit_Java_Commit/9730/testReport/junit/org.apache.beam.runners.fnexecution.control/DefaultJobBundleFactoryTest/loadBalancesBundles/]
>
> I have runner-core as tag but in reality this test is in
> org.apache.beam.runners.fnexecution.control but there is no corresponding tag
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
