[ 
https://issues.apache.org/jira/browse/BEAM-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241835#comment-17241835
 ] 

Brian Hulette commented on BEAM-11026:
--------------------------------------

Oh yes this would also require modifying BeamJarExpansionService to interpret 
maven coords rather than the gradle task.

One minor note on Tomasz's comment: I think we should allow (or require?) 
omitting the version, so its just {artifactId}:{groupId}. 
BeamJarExpansionService can infer the version from the version of the Python 
SDK (2.25.0.dev0 maps to 2.25.0-SNAPSHOT). In fact we might also allow omitting 
the artifactId and default it to "org.apache.beam".

> When determining expansion service jar, depend on Maven coords instead of 
> Gradle target
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-11026
>                 URL: https://issues.apache.org/jira/browse/BEAM-11026
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language, sdk-py-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Priority: P2
>
> For example here: 
> https://github.com/apache/beam/blob/release-2.24.0/sdks/python/apache_beam/io/kafka.py#L107
> Maven coords is more stable than the Gradle target name so it's better to 
> depend on the prior. See [1] for details.
> [1] https://issues.apache.org/jira/browse/BEAM-10986
>  
> cc: [~robertwb] [~bhulette] [~kenn]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to