[
https://issues.apache.org/jira/browse/BEAM-11363?focusedWorklogId=519805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-519805
]
ASF GitHub Bot logged work on BEAM-11363:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/20 18:19
Start Date: 03/Dec/20 18:19
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13444:
URL: https://github.com/apache/beam/pull/13444#discussion_r535472440
##########
File path: sdks/java/extensions/ml/build.gradle
##########
@@ -44,11 +44,30 @@ dependencies {
testRuntimeOnly project(":runners:google-cloud-dataflow-java")
}
-project.test {
- def gcpProject = project.findProperty("gcpProject") ?:
'apache-beam-testing'
- include "**/**IT.class"
- def pipelineOptions = [
- "--project=${gcpProject}"
- ]
- systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(pipelineOptions)
+/**
+ * These are integration tests with the GCP ML services and the DirectRunner.
+ */
+task integrationTest(type: Test) {
+ group = "Verification"
+ def gcpProject = project.findProperty('gcpProject') ?: 'apache-beam-testing'
+ def gcpTempRoot = project.findProperty('gcpTempRoot') ?:
'gs://temp-storage-for-end-to-end-tests'
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=DirectRunner",
+ "--project=${gcpProject}",
+ "--tempRoot=${gcpTempRoot}",
+ ])
+
+ // Disable Gradle cache: these ITs interact with live service that should
always be considered "out of date"
+ outputs.upToDateWhen { false }
Review comment:
I copied this from
https://github.com/apache/beam/blob/c5d5b9a090ecca1be932e9ae33126a1890e50564/sdks/java/extensions/google-cloud-platform-core/build.gradle#L76-L77
I can update the comments in both places to be more correct - it sounds like
just dropping "Disable Gradle cache:" would address it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 519805)
Time Spent: 50m (was: 40m)
> Integration tests are run under the test task
> ---------------------------------------------
>
> Key: BEAM-11363
> URL: https://issues.apache.org/jira/browse/BEAM-11363
> Project: Beam
> Issue Type: Bug
> Components: extensions-java-gcp
> Reporter: Niels Basjes
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As found in [https://github.com/apache/beam/pull/13308] the
> [https://github.com/apache/beam/blob/40f517f9da8b2f0914f06493f8e042eeb2739578/sdks/java/extensions/ml/build.gradle#L47-L49]
> explicitly includes the integration tests in the test task.
> As a consequence it is now impossible to run the tests without a google GCP
> account as the build will fail over missing account information.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
