[
https://issues.apache.org/jira/browse/BEAM-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244239#comment-17244239
]
Brian Hulette commented on BEAM-4422:
-------------------------------------
I looked into this a little. This issue was reported to gogradle [back in
2017|https://github.com/gogradle/gogradle/issues/181] and was supposed to be
resolved in [0.9|https://github.com/gogradle/gogradle/releases/tag/0.9].
Originally the fix, for 0.9, was a check for vendor directories
[here](https://github.com/gogradle/gogradle/blob/f6359d85fd9be6c770ac95ea6161efbe9a3d97cc/src/main/java/com/github/blindpirate/gogradle/task/go/GoVet.java#L65).
This changed in
https://github.com/gogradle/gogradle/commit/2b720e46dc0b73dc833c9995b1bf0e1afe8757d8.
Now it relies on either specifying the directory with "/..." (which I
understand is supposed to ignore vendor directories in go >= 1.9), or it uses
the GoSourceCodeFilter with PROJECT_ALL_FILES_ONLY, which is supposed to filter
out vendor directories.
This does not seem to be working at all, in fact it almost looks like were only
checking vendor directories:
{code}
> Build failed due to return code 1 of:
>
>
Command:
/home/bhulette/.gradle/go/binary/1.12/go/bin/go vet
github.com/apache/beam/sdks/go/test/load/vendor/google.golang.org/genproto/googleapis/cloud/bigquery/connection/v1beta1
github.com/apache/beam/sdks/go/test/load/vendor/cloud.goo
gle.com/go/dlp/apiv2
{code}
> 'gradlew check' build fails
> ---------------------------
>
> Key: BEAM-4422
> URL: https://issues.apache.org/jira/browse/BEAM-4422
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Colm O hEigeartaigh
> Priority: P3
>
> The following fails for me with "./gradlew check":
>
> Execution failed for task ':beam-sdks-go:vet'.
> > Build failed due to return code 1 of:
> Command:
> /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet
> /home/coheig/src/apache/beam/sdks/go/test
> /home/coheig/src/apache/beam/sdks/go/pkg
> /home/coheig/src/apache/beam/sdks/go/data
> /home/coheig/src/apache/beam/sdks/go/cmd
> /home/coheig/src/apache/beam/sdks/go/build
> /home/coheig/src/apache/beam/sdks/go/examples
> /home/coheig/src/apache/beam/sdks/go/container
> Env:
> GOEXE=
> GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
> GOROOT=/home/coheig/.gradle/go/binary/1.10/go
> GOOS=linux
> GOARCH=amd64
>
> [~herohde] provided more information on the mailing list:
>
> the error is "go vet" itself failing due to analyzing our dependencies under
> vendor:
> /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47|http://github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47]:
> Fprintln arg list ends with redundant newline
> /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54|http://github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54]:
> unreachable code
> /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276|http://github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276]:
> unreachable code
> [...]
> Not sure whether this is something we can fix in our configuration or
> whether it's rather a bug in the gogradle plugin. Given that there are no go
> vet problems in our code, we'd want that check to pass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
