[
https://issues.apache.org/jira/browse/BEAM-11357?focusedWorklogId=520309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-520309
]
ASF GitHub Bot logged work on BEAM-11357:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/20 19:14
Start Date: 04/Dec/20 19:14
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #13434:
URL: https://github.com/apache/beam/pull/13434#discussion_r536321232
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -188,6 +188,13 @@ message PTransform {
// Transforms that are required to be implemented by a runner must omit this.
// All other transforms are required to specify this.
string environment_id = 7;
+
+ // (Optional) A map from URNs designating a type of annotation, to the
+ // annotation in binary format. For example, an annotation could indicate
+ // that this PTransform has specific resource preferences.
+ //
+ // A runner MAY ignore types of annotations it doesn't understand.
Review comment:
I think we should add "Therefore annotations MUST NOT be used for
metadata that can affect correct execution of the transform."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 520309)
Time Spent: 50m (was: 40m)
> Support for annotations for transforms in Go SDK
> ------------------------------------------------
>
> Key: BEAM-11357
> URL: https://issues.apache.org/jira/browse/BEAM-11357
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Mirac Vuslat Basaran
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> See the [mail
> thread|https://lists.apache.org/thread.html/ra4f90560ac82bdbedfef36b3cd508da70ee7cf23383a0451d3875e45%40%3Cdev.beam.apache.org%3E]
> for a detailed explanation of the proposal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
