[
https://issues.apache.org/jira/browse/BEAM-11312?focusedWorklogId=520323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-520323
]
ASF GitHub Bot logged work on BEAM-11312:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/20 19:57
Start Date: 04/Dec/20 19:57
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #13399:
URL: https://github.com/apache/beam/pull/13399#discussion_r536345400
##########
File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py
##########
@@ -235,24 +235,26 @@ def invoke_docker_build_and_push(self,
container_image_name):
build.timeout = Duration().FromSeconds(seconds=1800)
now = time.time()
- _LOGGER.info(
- 'Building sdk container with google cloud build, this may '
- 'take a few minutes...')
operation = client.create_build(project_id=project_id, build=build)
- # if build fails exception will be raised and stops the job submission.
- try:
- result = operation.result()
- except Exception as e:
- build_lists = client.list_builds(
- project_id=project_id,
- filter="source.storage_source.bucket=\"%s\" AND source"
- ".storage_source.object=\"%s\"" % (gcs_bucket, gcs_object))
- for build in build_lists:
- _LOGGER.error("Build failed, check log at %s" % build.log_url)
- raise e
_LOGGER.info(
- "Python SDK container pre-build finished in %.2f seconds, "
- "check build log at %s" % (time.time() - now, result.log_url))
+ 'Building sdk container with google cloud build, this may '
Review comment:
nit: s/`google cloud build`/`Google Cloud Build` here and below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 520323)
Time Spent: 4h 10m (was: 4h)
> When prebuilding workflow on CloudBuild fails, we should tell the user where
> to look for build logs, ideally a link, or a pointer where the build logs are.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-11312
> URL: https://issues.apache.org/jira/browse/BEAM-11312
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Current error does not have context:
> ...
> /apache_beam/runners/portability/sdk_container_builder.py", line 242, in
> invoke_docker_build_and_push
> result = operation.result()
> File
> "/usr/local/google/home/valentyn/.pyenv/versions/py37prebuild/lib/python3.7/site-packages/google/api_core/future/polling.py",
> line 134, in result
> raise self._exception
> google.api_core.exceptions.Unknown: None Build failed;
> check build logs for details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
