[
https://issues.apache.org/jira/browse/BEAM-6540?focusedWorklogId=192977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192977
]
ASF GitHub Bot logged work on BEAM-6540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 18:51
Start Date: 31/Jan/19 18:51
Worklog Time Spent: 10m
Work Description: dustin12 commented on pull request #7664: [BEAM-6540]
Windmill quota piping
URL: https://github.com/apache/beam/pull/7664#discussion_r252794153
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -586,7 +594,12 @@ protected AbstractWindmillStream(
protected abstract void onNewStream();
/** Returns whether there are any pending requests that should be retried
on a stream break. */
protected abstract boolean hasPendingRequests();
-
+ /**
+ * Called when the stream is throttled due to resource exhausted errors.
Will be called for each
+ * resource exhausted error not just the first. onResponse() must stop
throttling on reciept of
+ * the first good message.
+ */
+ protected abstract void startThrottle();
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 192977)
Time Spent: 2.5h (was: 2h 20m)
> Autoscaling should be aware of Streaming RPC Quota
> ---------------------------------------------------
>
> Key: BEAM-6540
> URL: https://issues.apache.org/jira/browse/BEAM-6540
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Affects Versions: 2.11.0
> Reporter: Dustin Rhodes
> Assignee: Tyler Akidau
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Streaming Windmill Service introduces quota for the shared windmill workers.
> Autoscaling needs to be aware of throttling due to this quota in order to not
> upscale. This PR adds in that reporting.
>
> It also introduces the flag --EnableStreamingEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
