[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=521420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521420
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/20 22:30
Start Date: 07/Dec/20 22:30
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r537882276
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1112,6 +1128,17 @@ def run_ParDo(self, transform_node, options):
if is_stateful_dofn:
step.add_property(PropertyNames.USES_KEYED_STATE, 'true')
+ # Also checks whether the step allows shardable keyed states.
+ for pcoll in transform_node.outputs.values():
Review comment:
Got it. Yes I have a cl pending for adding translation to the service
which is waiting for this PR :) We are not considering adding this feature
patch for python runner v1 jobs though; it is disabled for non-unified worker:
https://github.com/apache/beam/blob/c1541796435cbd2ee775b6c89ec628f8564a3bcd/sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py#L365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 521420)
Time Spent: 14.5h (was: 14h 20m)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
