[
https://issues.apache.org/jira/browse/BEAM-10114?focusedWorklogId=522364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522364
]
ASF GitHub Bot logged work on BEAM-10114:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/20 17:44
Start Date: 09/Dec/20 17:44
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#13470:
URL: https://github.com/apache/beam/pull/13470#discussion_r539514951
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java
##########
@@ -64,8 +64,8 @@ private PubsubLiteIO() {}
* .build()), "read");
* }</pre>
*/
- public static Read.Unbounded<SequencedMessage> read(SubscriberOptions
options) {
- return Read.from(new PubsubLiteUnboundedSource(options));
+ public static PTransform<PBegin, PCollection<SequencedMessage>>
read(SubscriberOptions options) {
Review comment:
I don't (it adds to the api surface for an uncommon case), but this can
be implemented in userland by:
```
PCollectionList list = PCollectionList.of();
for (SubscriptionPath subscription : subscriptions) {
list = list.and(p.apply(PubsubLiteIO.read(SubscriberOptions.newBuilder()
.setSubscriptionPath(subscriptionPath)
.build()), "read"));
}
return list.apply(Flatten.<SequencedMessage>pCollections())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522364)
Time Spent: 14h 50m (was: 14h 40m)
> Add Pub/Sub Lite IO to beam builtin
> -----------------------------------
>
> Key: BEAM-10114
> URL: https://issues.apache.org/jira/browse/BEAM-10114
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Daniel Collins
> Priority: P3
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The IO currently lives [on the pubsub lite
> github|[https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io]]
> but should be moved to being part of beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
