[
https://issues.apache.org/jira/browse/BEAM-11425?focusedWorklogId=522390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522390
]
ASF GitHub Bot logged work on BEAM-11425:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/20 19:07
Start Date: 09/Dec/20 19:07
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #13505:
URL: https://github.com/apache/beam/pull/13505#discussion_r539571853
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/execute.go
##########
@@ -122,3 +135,21 @@ func PrintJob(ctx context.Context, job *df.Job) {
}
log.Info(ctx, string(str))
}
+
+type dataflowPipelineResult struct {
+ JobID string
Review comment:
SGTM for JobID. Remember that in Go it's not necessary to return the
exact interface that's supported every time. If the dataflow results or the
flink results need different method sets, they can export different methods,
and just document what are available on a custom results interface, that can be
type asserted to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522390)
Time Spent: 2h (was: 1h 50m)
> [Go SDK] Support metrics querying (Dataflow)
> --------------------------------------------
>
> Key: BEAM-11425
> URL: https://issues.apache.org/jira/browse/BEAM-11425
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The idea of querying metrics described in the parent ticket doesn't apply to
> Dataflow runner. Instead, we can get metrics from Monitoring API (this is how
> it works in Python SDK:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
