[
https://issues.apache.org/jira/browse/BEAM-10114?focusedWorklogId=522541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522541
]
ASF GitHub Bot logged work on BEAM-10114:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/20 04:45
Start Date: 10/Dec/20 04:45
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#13470:
URL: https://github.com/apache/beam/pull/13470#discussion_r539841781
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java
##########
@@ -64,8 +64,8 @@ private PubsubLiteIO() {}
* .build()), "read");
* }</pre>
*/
- public static Read.Unbounded<SequencedMessage> read(SubscriberOptions
options) {
- return Read.from(new PubsubLiteUnboundedSource(options));
+ public static PTransform<PBegin, PCollection<SequencedMessage>>
read(SubscriberOptions options) {
Review comment:
Yeah I don't agree. Reading from multiple subscriptions to process the
same data is a niche use-case: especially given that we try to commit to not
only never breaking API but the internal structure to prevent from breaking
dataflow refreshing, I think we should keep the API surface as small as
possible. Given how niche this is and how easy it is (5 LOC), I see no benefit
in adding noise to the API surface of PubsubLiteIO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522541)
Time Spent: 17h 20m (was: 17h 10m)
> Add Pub/Sub Lite IO to beam builtin
> -----------------------------------
>
> Key: BEAM-10114
> URL: https://issues.apache.org/jira/browse/BEAM-10114
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Daniel Collins
> Priority: P3
> Time Spent: 17h 20m
> Remaining Estimate: 0h
>
> The IO currently lives [on the pubsub lite
> github|[https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io]]
> but should be moved to being part of beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
