[
https://issues.apache.org/jira/browse/BEAM-11338?focusedWorklogId=523448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523448
]
ASF GitHub Bot logged work on BEAM-11338:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/20 18:03
Start Date: 12/Dec/20 18:03
Worklog Time Spent: 10m
Work Description: ccciudatu commented on a change in pull request #13539:
URL: https://github.com/apache/beam/pull/13539#discussion_r541698496
##########
File path:
sdks/java/io/thrift/src/test/java/org/apache/beam/sdk/io/thrift/ThriftIOTest.java
##########
@@ -240,15 +240,15 @@ public void testThriftCoder() {
// Generate random string
String randomString = RandomStringUtils.random(10, true, false);
short s = (short) RandomUtils.nextInt(0, Short.MAX_VALUE + 1);
- temp.stringIntMap = new HashMap<>();
- temp.stringIntMap.put(randomString, s);
- temp.testShort = s;
- temp.testBinary = buffer;
- temp.testBool = RandomUtils.nextBoolean();
- temp.testByte = (byte) RandomUtils.nextInt(0, Byte.MAX_VALUE + 1);
- temp.testDouble = RandomUtils.nextDouble();
- temp.testInt = RandomUtils.nextInt();
- temp.testLong = RandomUtils.nextLong();
Review comment:
The ThriftIO tests used to rely on fields being public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 523448)
Time Spent: 6h (was: 5h 50m)
> Beam schema for thrift data
> ---------------------------
>
> Key: BEAM-11338
> URL: https://issues.apache.org/jira/browse/BEAM-11338
> Project: Beam
> Issue Type: New Feature
> Components: io-java-utilities
> Reporter: Costi Ciudatu
> Assignee: Costi Ciudatu
> Priority: P2
> Labels: thrift
> Fix For: 2.27.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Define a SchemaProvider that can handle thrift objects, the same way as
> ProtoMessageSchema handles protobuf.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
