[
https://issues.apache.org/jira/browse/BEAM-1132?focusedWorklogId=193203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193203
]
ASF GitHub Bot logged work on BEAM-1132:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/19 03:28
Start Date: 01/Feb/19 03:28
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7699:
[BEAM-1132] add jacoco report on javaPreCommit
URL: https://github.com/apache/beam/pull/7699#discussion_r252923504
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -300,7 +300,7 @@ class BeamModulePlugin implements Plugin<Project> {
project.gradle.taskGraph.whenReady { graph ->
// Disable jacoco unless report requested such that task outputs can be
properly cached.
//
https://discuss.gradle.org/t/do-not-cache-if-condition-matched-jacoco-agent-configured-with-append-true-satisfied/23504
- def enabled = graph.allTasks.any { it instanceof JacocoReport }
+ def enabled = graph.allTasks.any { it instanceof JacocoReport ||
it.name.contains("javaPreCommit") }
Review comment:
A few ideas here:
- We want contributors to be able to reproduce `:javaPreCommit` on their
box. So that task is not a dedicated Jenkins task and we might not want this.
- To always activate on Jenkins, how about the straightforward
`-Pjenkins=true` ?
- What does this look like if we alter the plugin to make `jacocoReport`
depend on `test`? That way if you run `jacocoReport` it always runs all the
tests anyhow, so we can just invoke it as the main target. There is some
funkiness around the needsRunnerTests and validatesRunnerTests that we can
solve later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193203)
Time Spent: 50m (was: 40m)
> Jenkins JaCoCo plugin for Beam
> ------------------------------
>
> Key: BEAM-1132
> URL: https://issues.apache.org/jira/browse/BEAM-1132
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Jenkins has a JaCoCo plugin and other Apache projects use it. We should try
> it too (and might as well disable coveralls, as I don't know anyone who looks
> at it).
> If this takes more than 10 minutes to set up, then another option is to just
> archive JaCoCo's HTML reports so we can browse them.
> Either of these should take just minutes and yield huge benefits in
> visibility of where we have really bad coverage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
