[
https://issues.apache.org/jira/browse/BEAM-11474?focusedWorklogId=524687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524687
]
ASF GitHub Bot logged work on BEAM-11474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 20:14
Start Date: 15/Dec/20 20:14
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #13533:
URL: https://github.com/apache/beam/pull/13533#issuecomment-745540192
> > Currently you have recorded the threadId-transformId mapping on
> >
> > * startBundle
> > * finishBundle
> > * processElementForWindowObservingParDo
> > * processElementForParDo
> >
> > There are some other places we also invoke user code:
> >
> > * processElementForWindowObservingPairWithRestriction
> > * processElementForPairWithRestriction
> > * processElementForWindowObservingSplitRestriction
> > * processElementForSplitRestriction
> > * processElementForWindowObservingTruncateRestriction
> > * processElementForTruncateRestriction
> > * processElementForWindowObservingSizedElementAndRestriction
> > * tearDown
> > * invoke timer callback
>
> Do you think the step info will be useful for the logs in SDF related
callbacks? I haven't added for them since I'm not familiar how user would use
logging in SDFs but sure we can add tracking for all of them if necessary.
`SDF` indeed is a `DoFn`, not a callback. The SDF author could add
additional logging just like in a normal DoFn. If the purpose of this PR is to
add step info for the log that users add in their code, then I think we should
all these places where we will invoke user code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524687)
Time Spent: 50m (was: 40m)
> Populate transform id field in Java SDK harness logs.
> -----------------------------------------------------
>
> Key: BEAM-11474
> URL: https://issues.apache.org/jira/browse/BEAM-11474
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The Java SDK harness currently doesn't associate transform id with the logs
> sent to the runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
