[
https://issues.apache.org/jira/browse/BEAM-11358?focusedWorklogId=525198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525198
]
ASF GitHub Bot logged work on BEAM-11358:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/20 18:43
Start Date: 16/Dec/20 18:43
Worklog Time Spent: 10m
Work Description: rHermes commented on pull request #13435:
URL: https://github.com/apache/beam/pull/13435#issuecomment-746806274
> Thanks for your work @rHermes !
> Only some minor fixes and an important comment.
> Nexmark execution times are similar to CI. So LGTM
> On piece of advice, it is your second cleaning PR on nexmark. Next time,
could you please consider submitting cleaning PRs all in a single PR with
separate commits with explicit messages? thanks
I thought it was better practice to create separate PRs, but it's easier for
me to just combine them, so I'll do that next time :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 525198)
Time Spent: 2h 10m (was: 2h)
> Merge redundant metrics from nexmark monitors and remove unused monitor from
> endOfStreamMonitor
> ------------------------------------------------------------------------------------------------
>
> Key: BEAM-11358
> URL: https://issues.apache.org/jira/browse/BEAM-11358
> Project: Beam
> Issue Type: Improvement
> Components: testing-nexmark
> Affects Versions: 2.25.0
> Reporter: Teodor Spæren
> Assignee: Teodor Spæren
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The endOfStreamMonitor in the NexmarkQuery class is not used. The monitor
> class also had start and end distributions, which used the same values. This
> PR removes the unused monitor and merges the start and end distributions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
