[
https://issues.apache.org/jira/browse/BEAM-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251360#comment-17251360
]
Kenneth Knowles commented on BEAM-11436:
----------------------------------------
Yea let's just turn them off for test classes. It will speed up raw compile,
too.
I do have a pet peeve of bogus tests passing "null" for all the parameters they
think shouldn't matter (even when those parameters are not nullable) and
causing spurious failures.
I also have a pet peeve about tests having a lot of setup in the @Setup method,
when really each test case probably should have inline readable setup.
So I really like a lot of what checker makes you do for tests :-)
But I think just turning them off is the best compromise.
> Nullness checks are excessive for test classes
> ----------------------------------------------
>
> Key: BEAM-11436
> URL: https://issues.apache.org/jira/browse/BEAM-11436
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Kenneth Knowles
> Priority: P2
>
> We don't have checkerframework nullness annotations for JUnit, which often
> leads to difficult nullness errors. The most onerous is that assertNotNull
> requires the argument to be NonNull already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
