[
https://issues.apache.org/jira/browse/BEAM-11482?focusedWorklogId=526502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526502
]
ASF GitHub Bot logged work on BEAM-11482:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/20 12:48
Start Date: 20/Dec/20 12:48
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r546372051
##########
File path:
sdks/java/io/thrift/src/main/java/org/apache/beam/sdk/io/thrift/ThriftSchema.java
##########
@@ -183,7 +184,12 @@ private Schema schemaFor(Class<?> targetClass) {
private Schema.Field beamField(FieldMetaData fieldDescriptor) {
try {
final FieldType type = beamType(fieldDescriptor.valueMetaData);
- return Schema.Field.nullable(fieldDescriptor.fieldName, type);
+ switch (fieldDescriptor.requirementType) {
Review comment:
Well. it's purely cosmetic, I agree that switch is more readable and
makes it clear that there are another options. I'd leave it as it is. Listing
all the remaining options is definitely redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 526502)
Time Spent: 4h 40m (was: 4.5h)
> Thrift support for KafkaTableProvider
> -------------------------------------
>
> Key: BEAM-11482
> URL: https://issues.apache.org/jira/browse/BEAM-11482
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql, io-java-kafka
> Reporter: Costi Ciudatu
> Assignee: Costi Ciudatu
> Priority: P2
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Kafka table provider can leverage the Thrift coder and schema provider
> defined in the IO package to handle thrift input/output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
