[
https://issues.apache.org/jira/browse/BEAM-11482?focusedWorklogId=527263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527263
]
ASF GitHub Bot logged work on BEAM-11482:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 16:27
Start Date: 22/Dec/20 16:27
Worklog Time Spent: 10m
Work Description: chrlarsen commented on a change in pull request #13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r547374291
##########
File path:
sdks/java/io/thrift/src/main/java/org/apache/beam/sdk/io/thrift/ThriftCoder.java
##########
@@ -72,15 +71,13 @@ protected ThriftCoder(Class<T> type, TProtocolFactory
protocolFactory) {
*/
@Override
public void encode(T value, OutputStream outStream) throws CoderException,
IOException {
- ByteArrayOutputStream baos = new ByteArrayOutputStream();
- TProtocol protocol = protocolFactory.getProtocol(new
TIOStreamTransport(baos));
+ TProtocol protocol = protocolFactory.getProtocol(new
TIOStreamTransport(outStream));
Review comment:
LGTM. I think this was an artifact from earlier development.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527263)
Time Spent: 12h 20m (was: 12h 10m)
> Thrift support for KafkaTableProvider
> -------------------------------------
>
> Key: BEAM-11482
> URL: https://issues.apache.org/jira/browse/BEAM-11482
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql, io-java-kafka
> Reporter: Costi Ciudatu
> Assignee: Costi Ciudatu
> Priority: P2
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Kafka table provider can leverage the Thrift coder and schema provider
> defined in the IO package to handle thrift input/output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
