[
https://issues.apache.org/jira/browse/BEAM-11512?focusedWorklogId=527751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527751
]
ASF GitHub Bot logged work on BEAM-11512:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/20 18:35
Start Date: 23/Dec/20 18:35
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #13597:
URL: https://github.com/apache/beam/pull/13597#issuecomment-750423282
> I don't think this will fix the issue since even if the sdk.properties is
regenerated, it will be ignored for the purposes of that test.
Yeah, you're right. But at least the updated sdk.properties will be included
in jars if they're rebuilt for some other reason.
> What we need to do is ignore only the timestamp in the sdk.properties file.
Or we could just remove the timestamp? I don't think it's used anywhere. The
only place that reads from sdk.properties is
[ReleaseInfo.java](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java),
and it doesn't seem to read the timestamp at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527751)
Time Spent: 1h 40m (was: 1.5h)
> sdk.properties is often (always?) stale.
> ----------------------------------------
>
> Key: BEAM-11512
> URL: https://issues.apache.org/jira/browse/BEAM-11512
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I'm not sure when sdk.properties is rebuilt, but it is not often (perhaps it
> is only regenerated on a clean build). `./gradlew
> :sdks:java:core:processResources` never does anything, it always reports
> being up to date.
> One consequence of this is that when the SDK version property in Gradle
> changes, sdk.properties does not change. We rely on sdk.properties to get the
> default Java SDK container version tag, among other things, so this causes
> the default container environment to become incorrect.
>
> For example, this caused cross language tests to fail on the release branch
> because they looked for the wrong Java SDK container.
> https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/179/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
