[
https://issues.apache.org/jira/browse/BEAM-6545?focusedWorklogId=193514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193514
]
ASF GitHub Bot logged work on BEAM-6545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/19 19:49
Start Date: 01/Feb/19 19:49
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7698: [BEAM-6545]
Cherrypick #7667 to release-2.10.0: Remove useless allowance of null
constructor in ByteArrayShufflePosition
URL: https://github.com/apache/beam/pull/7698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193514)
Time Spent: 50m (was: 40m)
> NPE when decoding null base 64 strings
> --------------------------------------
>
> Key: BEAM-6545
> URL: https://issues.apache.org/jira/browse/BEAM-6545
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.9.0
> Reporter: Ahmet Altay
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> **ByteArrayShufflePosition.fromBase64 is marked with a @Nullable argument,
> however it does not properly handle null inputs resulting in NPE.
> This seems like an unintended change we picked up from the dependency:
> google-http-java-client/ switched from apache commons to guava
> ([https://github.com/googleapis/google-http-java-client/commit/990c534f0e5103a142b0639c12c90cb990a00cfd#diff-97264fba16d690a26d63fbbc992af937)]
>
>
> and decodeBase64 behaves differently in both cases. Former can handle null by
> returning null, latter will throw NPE.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
