[
https://issues.apache.org/jira/browse/BEAM-11482?focusedWorklogId=528023&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528023
]
ASF GitHub Bot logged work on BEAM-11482:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Dec/20 08:03
Start Date: 24/Dec/20 08:03
Worklog Time Spent: 10m
Work Description: ccciudatu commented on a change in pull request #13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r548438382
##########
File path:
sdks/java/io/thrift/src/main/java/org/apache/beam/sdk/io/thrift/ThriftSchema.java
##########
@@ -243,37 +253,65 @@ private FieldValueTypeInformation
fieldValueTypeInfo(Class<?> type, String field
@Override
public @NonNull SchemaUserTypeCreator schemaTypeCreator(
@NonNull Class<?> targetClass, @NonNull Schema schema) {
- return params -> restoreThriftObject(targetClass, params);
+ return thriftMapper(targetClass, schema);
+ }
+
+ private <FieldT extends Enum<FieldT> & TFieldIdEnum, T extends TBase<T,
FieldT>>
+ SchemaUserTypeCreator thriftMapper(Class<?> targetClass, Schema schema) {
Review comment:
this method only exists for "pinning" the generics between the two
invocations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 528023)
Time Spent: 17h (was: 16h 50m)
> Thrift support for KafkaTableProvider
> -------------------------------------
>
> Key: BEAM-11482
> URL: https://issues.apache.org/jira/browse/BEAM-11482
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql, io-java-kafka
> Reporter: Costi Ciudatu
> Assignee: Costi Ciudatu
> Priority: P2
> Time Spent: 17h
> Remaining Estimate: 0h
>
> Kafka table provider can leverage the Thrift coder and schema provider
> defined in the IO package to handle thrift input/output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
