[
https://issues.apache.org/jira/browse/BEAM-6138?focusedWorklogId=193587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193587
]
ASF GitHub Bot logged work on BEAM-6138:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/19 00:45
Start Date: 02/Feb/19 00:45
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #7624: [BEAM-6138]
Set the PTransform name on Java SDK User counters
URL: https://github.com/apache/beam/pull/7624#discussion_r253242021
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -89,7 +89,7 @@ public String getUrn() {
return this.labels;
}
- /** @return a MetricName for a specific urn and labels map. */
+ /** @return a MonitoringInfoMetricName for a specific urn and labels map. */
Review comment:
Unless it is forced by linter, this comment is obsolete, since it repeats
method signature without adding extra information.
Method can be renamed to generateMetricName for readability.
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193587)
Time Spent: 7.5h (was: 7h 20m)
> Add User Metric Support to Java SDK
> -----------------------------------
>
> Key: BEAM-6138
> URL: https://issues.apache.org/jira/browse/BEAM-6138
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
