[
https://issues.apache.org/jira/browse/BEAM-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759662#comment-16759662
]
Robert Burke edited comment on BEAM-6577 at 2/4/19 7:13 AM:
------------------------------------------------------------
I think the only place that fails for this, would be for the struct closure
generator.
[https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/shimx/generate.go#L255]
Is that the failure case you find?
Otherwise I don't think return types are explicitly referred to in the
generated file, and thus, no imports.
was (Author: lostluck):
I think the only place that fails for this, would be for the struct closure
generator.
[https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/shimx/generate.go#L255]
> The shim generator doesn't examine func return types when generating
> necessary imports
> --------------------------------------------------------------------------------------
>
> Key: BEAM-6577
> URL: https://issues.apache.org/jira/browse/BEAM-6577
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Tianyang Hu
> Assignee: Robert Burke
> Priority: Major
>
> For the following function:
> {code:java}
> func myDoFn(s string) mypkg.MyType {...}
> {code}
> it's shim generated code doesn't import "mypkg", which leads to compilation
> error "undefined mypkg..."
> Seems that the func parser inspects only the input params, not return params:
> https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/starcgenx/starcgenx.go#L293
> Should we do the same for return types?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
