[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=193949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193949
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/19 10:09
Start Date: 04/Feb/19 10:09
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7682: [BEAM-5959]
Add GCS KMS support
URL: https://github.com/apache/beam/pull/7682#discussion_r253399708
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java
##########
@@ -205,11 +226,16 @@ private GcsUtil(
Storage storageClient,
HttpRequestInitializer httpRequestInitializer,
ExecutorService executorService,
- @Nullable Integer uploadBufferSizeBytes) {
+ @Nullable Integer uploadBufferSizeBytes,
Review comment:
I just noticed a pattern we 'addressed` in the AWS side, usually when code
evolves objects like `GcsUtil` start to get filled with parameters that are
just extracting values from the `Options`. Maybe just storing the options as an
attribute can make the code simpler and evolution easier. Worth doing it (not a
blocking for the PR but nice to have).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193949)
Time Spent: 20.5h (was: 20h 20m)
> Add Cloud KMS support to GCS creates and copies
> -----------------------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 20.5h
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
