[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=529381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529381
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/20 04:57
Start Date: 30/Dec/20 04:57
Worklog Time Spent: 10m
Work Description: shehzaadn-vd edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-752327457
> @kennknowles @ibzib any idea why
org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement
is showing up as failing even though it's excluded from running in
beam/runners/portability/java/build.gradle
> (excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement')
Did some digging around -
1) The task that's calling this failing test is
:runners:direct-java:needsRunnerTests
2) Looking at the console output of the last successful build (#15306),
(taking the listing of tasks on the left and doing some sort/uniq/diff on bash)
this is the *only* task that actually gets called twice . Not sure if that's
expected. Seems strange for a task to be executed twice.
3) In this build (#15307), we have the following tasks that are being called
twice: :runners:direct-java:needsRunnerTests, :runners:flink:1.10:test,
:runners:flink:1.11:test, :runners:samza:compileTestJava
Could this failure be related to the same test being called more than once
in the same runtime instance. Is it worth looking into removing this duplicate
calling of tasks? Or maybe there's a simpler answer....
@kennknowles @ibzib
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529381)
Time Spent: 25h 40m (was: 25.5h)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 25h 40m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
