[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=529761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529761
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Dec/20 10:53
Start Date: 31/Dec/20 10:53
Worklog Time Spent: 10m
Work Description: sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550450329
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
`:runners:flink:1.10:job-server:analyzeClassesDependencies `task fails
if we don't add `permitUnusedDeclared project(":runners:flink:1.10")`
```
Task :runners:flink:1.10:job-server:analyzeClassesDependencies FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task
':runners:flink:1.10:job-server:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts:
- beam.runners.flink:1.10:2.28.0-SNAPSHOT@jar
```
As it is transitively being declared, but we do not need it here. Thats why
it is important to declare it permitUnsedDeclared.
@ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529761)
Time Spent: 29.5h (was: 29h 20m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 29.5h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
