[
https://issues.apache.org/jira/browse/BEAM-11572?focusedWorklogId=531793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531793
]
ASF GitHub Bot logged work on BEAM-11572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 10:15
Start Date: 06/Jan/21 10:15
Worklog Time Spent: 10m
Work Description: anantdamle commented on pull request #13673:
URL: https://github.com/apache/beam/pull/13673#issuecomment-755212304
> Seems there is another error in the nexmark module. I will let you and
@ibzib follow with this review (that will give me some extra time to finish
other stuff). Thanks.
>
> ```
> 09:11:50 > Task :sdks:java:testing:nexmark:checkstyleMain
> 09:11:50 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@2/src/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/NexmarkQueryModel.java:102:
Using deprecated Assert.assertThat. Please use MatcherAssert.assertThat.
[ForbidDeprecatedAssertThat]
> ```
Thanks @iemejia fixed that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 531793)
Time Spent: 1h 50m (was: 1h 40m)
> Use MatcherAssert#assertThat instead of deprecated Assert#assertThat
> --------------------------------------------------------------------
>
> Key: BEAM-11572
> URL: https://issues.apache.org/jira/browse/BEAM-11572
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Affects Versions: 2.26.0
> Reporter: Anant Damle
> Assignee: Anant Damle
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Beam tests uses *deprecated*
> [Assert#assertThat|https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat(T,%20org.hamcrest.Matcher)]
> which needs to be changed to
> [MatcherAssert#assertThat|https://junit.org/junit4/javadoc/latest/org/hamcrest/MatcherAssert.html#assertThat(T,%20org.hamcrest.Matcher)]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
