[
https://issues.apache.org/jira/browse/BEAM-11415?focusedWorklogId=532190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532190
]
ASF GitHub Bot logged work on BEAM-11415:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 23:13
Start Date: 06/Jan/21 23:13
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #13678:
URL: https://github.com/apache/beam/pull/13678#discussion_r553011431
##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -151,11 +222,70 @@ if [[ "$RUNNER" == "flink" || "$RUNNER" == "spark" ||
"$RUNNER" == "portable" ]]
java -jar $EXPANSION_SERVICE_JAR $EXPANSION_PORT &
EXPANSION_PID=$!
fi
+fi
+
+if [[ "$RUNNER" == "dataflow" ]]; then
+ # Verify docker and gcloud commands exist
+ command -v docker
+ docker -v
+ command -v gcloud
+ gcloud --version
+
+ # ensure gcloud is version 186 or above
+ TMPDIR=$(mktemp -d)
+ gcloud_ver=$(gcloud -v | head -1 | awk '{print $4}')
+ if [[ "$gcloud_ver" < "186" ]]
+ then
+ pushd $TMPDIR
+ curl
https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-186.0.0-linux-x86_64.tar.gz
--output gcloud.tar.gz
+ tar xf gcloud.tar.gz
+ ./google-cloud-sdk/install.sh --quiet
+ . ./google-cloud-sdk/path.bash.inc
+ popd
+ gcloud components update --quiet || echo 'gcloud components update failed'
+ gcloud -v
+ fi
- ARGS="$ARGS --endpoint=$ENDPOINT --expansion_addr=$EXPANSION_ADDR"
+ # Build the container
+ TAG=$(date +%Y%m%d-%H%M%S)
+ CONTAINER=us.gcr.io/$PROJECT/$USER/beam_go_sdk
Review comment:
Hmm, looks like it. When I copied the code over I didn't notice that no
USER variable was defined. On the other hand, this is just used to generate a
directory for the script to store containers, so it's probably unnecessary to
have a flag for this unless it causes problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532190)
Time Spent: 4h 20m (was: 4h 10m)
> Create ValidatesRunner test framework for the Go SDK.
> -----------------------------------------------------
>
> Key: BEAM-11415
> URL: https://issues.apache.org/jira/browse/BEAM-11415
> Project: Beam
> Issue Type: Test
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> I've actually already started working on this and it's ending up being more
> like an expansion on the existing integration test system.
> Current main improvements this will add:
> * The new approach is based on the go testing framework, meaning tests do not
> need to be manually registered with a driver. This is bug for usability and
> scalability as more tests will need to be added.
> * Will allow tests to be run with the "go test ..." command, assuming
> necessary services are running.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
