[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=532535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532535
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/21 14:57
Start Date: 07/Jan/21 14:57
Worklog Time Spent: 10m
Work Description: sonam-vend commented on a change in pull request #13688:
URL: https://github.com/apache/beam/pull/13688#discussion_r553378917
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -57,6 +59,13 @@ dependencies {
compile library.java.jackson_databind
compile "org.springframework:spring-expression:4.3.18.RELEASE"
compile ("io.confluent:kafka-avro-serializer:5.3.2") {
+ // zookeeper depends on "spotbugs-annotations:3.1.9" which clashes with
current
+ // "spotbugs-annotations:3.1.12" used in Beam. Not required.
+ exclude group: "org.apache.zookeeper", module: "zookeeper"
+ // "kafka-clients" has to be provided since user can use its own version.
+ exclude group: "org.apache.kafka", module: "kafka-clients"
Review comment:
For `:sdks:java:container:generateLicenseReport` to succeed, had to
exclude kafka-clients and zookeeper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532535)
Time Spent: 37h (was: 36h 50m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 37h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
