[
https://issues.apache.org/jira/browse/BEAM-11327?focusedWorklogId=532805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532805
]
ASF GitHub Bot logged work on BEAM-11327:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/21 02:06
Start Date: 08/Jan/21 02:06
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r553699566
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -86,7 +86,7 @@ public void write(int i) throws IOException {
this.logger = Logger.getLogger(loggerName);
this.buffer = new StringBuilder();
this.decoder =
- Charset.defaultCharset()
+ StandardCharsets.UTF_8
Review comment:
Well you'll also want to add an argument to `create()`, and update the
places that call it, for example in the test:
https://github.com/apache/beam/blob/df74d74ef295aa972b0d1ddef2429f427b988a25/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactoryTest.java#L168
Would become `return JulHandlerPrintStreamAdapterFactory.create(handler,
LOGGER_NAME, Level.INFO, StandardCharsets.UTF_8);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532805)
Time Spent: 6h 20m (was: 6h 10m)
> Replace Charset.defaultCharset() with StandardCharsets.UTF_8
> ------------------------------------------------------------
>
> Key: BEAM-11327
> URL: https://issues.apache.org/jira/browse/BEAM-11327
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Omar Ismail
> Assignee: Omar Ismail
> Priority: P2
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> When running tests where `getBytes(Charset.defaultCharset())` is called, and
> `locale` is not set to "UTF8", the test fails.
>
> I am going to replace all mentions of `Charset.defaultCharset()` to
> `StandardCharsets.UTF_8` so testing is not affected my computer settings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
