[
https://issues.apache.org/jira/browse/BEAM-11586?focusedWorklogId=533862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533862
]
ASF GitHub Bot logged work on BEAM-11586:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/21 04:26
Start Date: 10/Jan/21 04:26
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13711:
URL: https://github.com/apache/beam/pull/13711#discussion_r554262202
##########
File path: sdks/java/container/common.gradle
##########
@@ -60,8 +59,12 @@ task copySdkHarnessLauncher(type: Copy) {
into "build/target"
}
-task copyPulledLicenses(type: Copy) {
- from configurations.pulledLicenses
+task copyJavaThirdPartyLicenses(type: Copy) {
+ dependsOn ':sdks:java:container:pullLicenses'
+ from("${project(':sdks:java:container').buildDir}/build/target") {
+ include 'third_party_licenses/*'
+ include 'java_third_party_licenses/*'
Review comment:
[license_script.sh](https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/license_script.sh)
copies everything from `build/target/java_third_party_licenses` into
`build/target/third_party_licenses`, so IIUC we shouldn't copy
`java_third_party_licenses` again here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 533862)
Time Spent: 1h 10m (was: 1h)
> Container build always pulls licenses.
> --------------------------------------
>
> Key: BEAM-11586
> URL: https://issues.apache.org/jira/browse/BEAM-11586
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kyle Weaver
> Assignee: Emily Ye
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> ./gradlew :sdks:java:container:build runs the pullLicenses task.
> Pulling licenses is supposed to be opt-in only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
