[
https://issues.apache.org/jira/browse/BEAM-6577?focusedWorklogId=194293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194293
]
ASF GitHub Bot logged work on BEAM-6577:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/19 22:27
Start Date: 04/Feb/19 22:27
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #7720: [BEAM-6577]
Examine func return types when generating shims
URL: https://github.com/apache/beam/pull/7720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 194293)
Time Spent: 10m
Remaining Estimate: 0h
> The shim generator doesn't examine func return types when generating
> necessary imports
> --------------------------------------------------------------------------------------
>
> Key: BEAM-6577
> URL: https://issues.apache.org/jira/browse/BEAM-6577
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Tianyang Hu
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For the following function:
> {code:java}
> func myDoFn(s string) mypkg.MyType {...}
> {code}
> it's shim generated code doesn't import "mypkg", which leads to compilation
> error "undefined mypkg..."
> Seems that the func parser inspects only the input params, not return params:
> https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/starcgenx/starcgenx.go#L293
> Should we do the same for return types?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
