[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=534444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534444
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/21 19:02
Start Date: 11/Jan/21 19:02
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#13690:
URL: https://github.com/apache/beam/pull/13690#discussion_r555271950
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -855,9 +855,11 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become
a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:1.7.2",
"com.google.auto.service:auto-service-annotations:1.0-rc6",
"com.google.j2objc:j2objc-annotations:1.3",
+ "org.checkerframework:checker-qual:3.7.0",
Review comment:
These annotations do end up in the class files so users can benefit from
them.
Java spec is that annotations that cannot be resolved on the classpath
should be ignored. Unfortunately, the JDK has a bug (don't recall if/when it
was fixed) where it actually causes a crash.
See https://github.com/apache/beam/pull/13169 and
https://issues.apache.org/jira/browse/BEAM-10632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 534444)
Time Spent: 39h 20m (was: 39h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 39h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
