[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=535643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535643
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/21 19:16
Start Date: 13/Jan/21 19:16
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13690:
URL: https://github.com/apache/beam/pull/13690#discussion_r556767191
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -452,6 +452,8 @@ class BeamModulePlugin implements Plugin<Project> {
def spark_version = "2.4.7"
def spotbugs_version = "4.0.6"
def testcontainers_version = "1.15.1"
+ def jsr305_version = "3.0.2"
Review comment:
Nit: can you insert the new lines according to alphabetical order?
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -858,9 +860,10 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become
a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:$autovalue_version",
Review comment:
Nit: can you insert the new lines according to alphabetical order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535643)
Time Spent: 45h 20m (was: 45h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 45h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
