[
https://issues.apache.org/jira/browse/BEAM-10114?focusedWorklogId=535871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535871
]
ASF GitHub Bot logged work on BEAM-10114:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/21 04:37
Start Date: 14/Jan/21 04:37
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13567:
URL: https://github.com/apache/beam/pull/13567#discussion_r557039070
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java
##########
@@ -163,28 +161,6 @@ abstract Builder setBacklogReaderSupplier(
abstract Builder setOffsetReaderSupplier(
SerializableSupplier<InitialOffsetReader> offsetReaderSupplier);
- // Used for implementing build();
- abstract SubscriptionPath subscriptionPath();
-
- abstract Set<Partition> partitions();
-
- abstract SubscriberOptions autoBuild();
-
- @SuppressWarnings("CheckReturnValue")
- public SubscriberOptions build() throws ApiException {
- if (!partitions().isEmpty()) {
- return autoBuild();
- }
-
- if (partitions().isEmpty()) {
- int partitionCount =
PartitionLookupUtils.numPartitions(subscriptionPath());
- ImmutableSet.Builder<Partition> partitions = ImmutableSet.builder();
- for (int i = 0; i < partitionCount; i++) {
- partitions.add(Partition.of(i));
- }
- setPartitions(partitions.build());
- }
- return autoBuild();
- }
+ public abstract SubscriberOptions build();
Review comment:
You may want to highlight the ability of watching partitions growth when
`partitions()` is empty. This is the key information when users look into
javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535871)
Time Spent: 19h 20m (was: 19h 10m)
> Add Pub/Sub Lite IO to beam builtin
> -----------------------------------
>
> Key: BEAM-10114
> URL: https://issues.apache.org/jira/browse/BEAM-10114
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Daniel Collins
> Priority: P3
> Time Spent: 19h 20m
> Remaining Estimate: 0h
>
> The IO currently lives [on the pubsub lite
> github|[https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io]]
> but should be moved to being part of beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
