[
https://issues.apache.org/jira/browse/BEAM-11032?focusedWorklogId=536160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-536160
]
ASF GitHub Bot logged work on BEAM-11032:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/21 20:55
Start Date: 14/Jan/21 20:55
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #13491:
URL: https://github.com/apache/beam/pull/13491#discussion_r557692931
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -383,4 +409,70 @@ public boolean equals(@Nullable Object object) {
public int hashCode() {
return Objects.hash(stepName, counters, distributions, gauges);
}
+
+ private boolean equalsMetricName(MetricName metricName, String namespace,
String name) {
+ return (namespace == null || namespace.equals(metricName.getNamespace()))
Review comment:
Yeah, `equals` prefix is misleading. It's more like matching and when
the field will be ignored when the parameter is null. I renamed the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 536160)
Time Spent: 2h 20m (was: 2h 10m)
> Use metric for Java BigQuery streaming insert API latency logging
> -----------------------------------------------------------------
>
> Key: BEAM-11032
> URL: https://issues.apache.org/jira/browse/BEAM-11032
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Heejong Lee
> Priority: P2
> Labels: stale-P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Use metric for Java BigQuery streaming insert API latency logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
