[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=536311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-536311
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/21 04:08
Start Date: 15/Jan/21 04:08
Worklog Time Spent: 10m
Work Description: shehzaadn-vd edited a comment on pull request #13668:
URL: https://github.com/apache/beam/pull/13668#issuecomment-760574007
> @sonam-vend shouldn't we enable strict dependencies on each module as we
go, instead of waiting for every module to be fixed to start checking any of
them?
@ibzib Since #12938 is passing all checks, and all these PRs were split from
that one, @sonam-vend and I were thinking we'd likely have only a small-ish
number of issues (hopefully zero or thereabouts!) when we enable the switch at
the global level. Since eventually we'll be turning on the global switch
anyway, enabling strict dependencies at the module level would have to be
undone anyway. Hence the approach of turning on the global switch once the
individual PRs are merged. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 536311)
Time Spent: 50h 50m (was: 50h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 50h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
