[
https://issues.apache.org/jira/browse/BEAM-11411?focusedWorklogId=536692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-536692
]
ASF GitHub Bot logged work on BEAM-11411:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/21 01:29
Start Date: 16/Jan/21 01:29
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #13636:
URL: https://github.com/apache/beam/pull/13636#issuecomment-761285224
> Hi @aaltay we tried to turn this test into IT but ran into some troubles,
would be great if you could help us with them:
>
> 1. When running the test all Docker containers are starting in the machine
that is running the test,
> so in order for this test to work properly dataflow job should be able
to reach test-runner machine by a public IP.
> I certainly can't do it on my local machine, not sure how it will
behave when running in CI environment.
> 2. When we pass our fake PubSub url into the dataflow job we receive
following error, not sure how this can be avoided, looks like the job will only
accept the real Cloud PubSub url:
>
> ```json
> {
> "code" : 400,
> "errors" : [ {
> "domain" : "global",
> "message" : "(f214233f9dbe6968): The workflow could not be created.
Causes: (f214233f9dbe6719): http://localhost:49169 is not a valid Pub/Sub URL.",
> "reason" : "badRequest"
> } ],
> "message" : "(f214233f9dbe6968): The workflow could not be created.
Causes: (f214233f9dbe6719): http://localhost:49169 is not a valid Pub/Sub URL.",
> "status" : "INVALID_ARGUMENT"
> }
> ```
>
> FYI @TheNeuralBit
I do not know the answer to these questions, and you can try asking on the
dev@ list for a different answer.
However, this does not sounds like a feasible test plan. Because, we do not
generally use our test workers to mock services, and we generally do not want
jenkins workers to be publicly reachable. A better approach, as part of the
test setup, creating a new pubsub topic, publishing test messages there, let
the pipeline do its job and at the end of the pipeline check that pipeline
produced expected outputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 536692)
Time Spent: 6h (was: 5h 50m)
> Example of E2E test for Pub/Sub environment
> -------------------------------------------
>
> Key: BEAM-11411
> URL: https://issues.apache.org/jira/browse/BEAM-11411
> Project: Beam
> Issue Type: Improvement
> Components: examples-java
> Reporter: Ilya Kozyrev
> Priority: P2
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Kafka to Pub/Sub pipeline [example|https://github.com/apache/beam/pull/13112]
> needs to have e2e tests. However, in Beam Testing Guide
> [https://cwiki.apache.org/confluence/display/BEAM/Contribution+Testing+Guide]
> , we have not found examples or documentation for e2e tests that require a
> Pub/Sub environment can be set up.
> During the investigation and with the help of our reviewers we found possible
> approaches for our issue.
> For Pub/Sub, e2e test could use [Pub/Sub
> emulator|https://cloud.google.com/pubsub/docs/emulator]
> These e2e test examples can be referenced in the
> [https://cwiki.apache.org/confluence/display/BEAM/Contribution+Testing+Guide]
> to serve examples of how customers may approach e2e testing of pipelines in
> their environments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
