[
https://issues.apache.org/jira/browse/BEAM-9615?focusedWorklogId=537903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537903
]
ASF GitHub Bot logged work on BEAM-9615:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 17:01
Start Date: 19/Jan/21 17:01
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #13760:
URL: https://github.com/apache/beam/pull/13760#discussion_r560334776
##########
File path: sdks/go/pkg/beam/core/graph/coder/row.go
##########
@@ -24,13 +24,33 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
+var (
+ defaultEnc RowEncoderBuilder
+ defaultDec RowDecoderBuilder
+
+ // RequireAllFieldsExported when set to true will have the default
coder buildings using
+ // RowEncoderForStruct and RowDecoderForStruct fail if there are any
unexported fields.
+ // When set false, unexported fields in default destination structs
will be silently
+ // ignored when coding.
+ // This has no effect on types with registered coder providers.
+ RequireAllFieldsExported bool
Review comment:
Good call. Or you set it and never register providers, it never gets set
at all. Either way, not ideal.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537903)
Time Spent: 21h 10m (was: 21h)
> [Go SDK] Beam Schemas
> ---------------------
>
> Key: BEAM-9615
> URL: https://issues.apache.org/jira/browse/BEAM-9615
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 21h 10m
> Remaining Estimate: 0h
>
> Schema support is required for advanced cross language features in Beam, and
> has the opportunity to replace the current default JSON encoding of elements.
> Some quick notes, though a better fleshed out doc with details will be
> forthcoming:
> * All base coders should be implemented, and listed as coder capabilities. I
> think only stringutf8 is missing presently.
> * Should support fairly arbitrary user types, seamlessly. That is, users
> should be able to rely on it "just working" if their type is compatible.
> * Should support schema metadata tagging.
> In particular, one breaking shift in the default will be to explicitly fail
> pipelines if elements have unexported fields, when no other custom coder has
> been added. This has been a source of errors/dropped data/keys and a simply
> warning at construction time won't cut it. However, we could provide a manual
> "use beam schemas, but ignore unexported fields" registration as a work
> around.
> Edit: Doc is now at https://s.apache.org/beam-go-schemas
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
