[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=538154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538154
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 00:18
Start Date: 20/Jan/21 00:18
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r560587057
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
I think a better solution is to make `:runners:flink:1.x` a runtimeOnly
instead of dependency instead of a compile dependency in
flink_job_server.gradle, but I will do that in a separate PR since more changes
might be required. BEAM-11664
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_databind
+ compile "org.apache.flink:flink-annotations:$flink_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_version"
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_version"
Review comment:
Same here - since `compile
"org.apache.flink:flink-clients_2.11:$flink_version"` could safely be removed,
we no longer need `permitUnusedDeclared
"org.apache.flink:flink-clients_2.11:$flink_version"`.
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
I see `compile library.java.jackson_annotations` was removed. So there's
no need to have `permitUnusedDeclared library.java.jackson_annotations` anymore
because we are not declaring it (I don't think the plugin checks for
"transitive declaration," either we explicitly declare a dependency or we don't
declare it at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538154)
Time Spent: 58h (was: 57h 50m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 58h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
