[
https://issues.apache.org/jira/browse/BEAM-10402?focusedWorklogId=539770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539770
]
ASF GitHub Bot logged work on BEAM-10402:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 06:13
Start Date: 22/Jan/21 06:13
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13769:
URL: https://github.com/apache/beam/pull/13769#discussion_r562252293
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/SplitResult.java
##########
@@ -28,7 +28,7 @@
public abstract class SplitResult<RestrictionT> {
/** Returns a {@link SplitResult} for the specified primary and residual
restrictions. */
public static <RestrictionT> SplitResult<RestrictionT> of(
- RestrictionT primary, RestrictionT residual) {
+ @Nullable RestrictionT primary, @Nullable RestrictionT residual) {
Review comment:
Would the `@Nullabe` annotations below(L36 and L39) be enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539770)
Time Spent: 15h 10m (was: 15h)
> [Umbrella] Eliminate nullability errors from Beam Java
> ------------------------------------------------------
>
> Key: BEAM-10402
> URL: https://issues.apache.org/jira/browse/BEAM-10402
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P1
> Labels: Clarified, starter
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> I enabled the checker framework and the core SDK exceeds 100 nullability
> errors immediately. We should make this number zero, since nullability errors
> are solved problem in computer science and they do periodically impact Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
