[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=540305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540305
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 19:13
Start Date: 22/Jan/21 19:13
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #13688:
URL: https://github.com/apache/beam/pull/13688#issuecomment-765627816
> Basically, I'm proposing a split into 4 PRs. If you would prefer a
different split, please mark the sheet accordingly.
@shehzaadn-vd How about this:
- There are a number of files where the only change is setting
`enableStrictDependencies: true`, or others where the only changes are setting
`enableStrictDependencies: true` and removing `hamcrest_core` and
`hamcrest_library`. These are fine to bundle in a single PR because they are
trivial to review (I would LGTM immediately).
- Any files with larger diffs than that should go in their own PR, with the
exception of the following groups, which can get one PR each: amazon, hadoop,
and snowflake.
Another thought: it's also fine to set `enableStrictDependencies` on a file
and just `permit` every existing violation. From the description in the JIRA,
it seems the original intent was to first set `enableStrictDependencies`
globally and ignore all the existing violations, and second to gradually fix
all the existing violations. Step 1 is way easier than step 2 and has the
benefit of preventing future violations. Separating the two steps also has the
benefit that the `permit` clauses inserted in step 1 make reviewing step 2 a
lot easier. It seems we've skipped to step 2 here. Just something to keep in
mind in case step 2 is too difficult for some modules. cc @tysonjh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 540305)
Time Spent: 81h 50m (was: 81h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 81h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
