[
https://issues.apache.org/jira/browse/BEAM-8106?focusedWorklogId=540370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540370
]
ASF GitHub Bot logged work on BEAM-8106:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 22:19
Start Date: 22/Jan/21 22:19
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r562945561
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -246,9 +247,11 @@ def createRunnerV2ValidatesRunnerTest = { Map args ->
// task directly ('dependsOn buildAndPushDockerContainer'). This ensures the
correct
// task ordering such that the registry doesn't get cleaned up prior to task
completion.
task buildAndPushDockerContainer() {
- dependsOn ":sdks:java:container:docker"
+ def javaVer = project.hasProperty('compileAndRunTestsWithJava11') ? "java11"
: "java8"
+ dependsOn ":sdks:java:container:${javaVer}:docker"
+ finalizedBy 'cleanUpDockerImages'
Review comment:
The `finalizeBy` definition here breaks the Kafka Performance Test[1]
because it makes the docker image get cleaned up as soon as it is pushed.
We define the cleanup logic here:
https://github.com/apache/beam/blame/master/runners/google-cloud-dataflow-java/build.gradle#L280-L287
[1] https://ci-beam.apache.org/job/beam_PerformanceTests_Kafka_IO/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 540370)
Time Spent: 17h 10m (was: 17h)
> Publish Java 11 SDK Harness docker image
> ----------------------------------------
>
> Key: BEAM-8106
> URL: https://issues.apache.org/jira/browse/BEAM-8106
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, sdk-java-harness
> Reporter: Hannah Jiang
> Assignee: Emily Ye
> Priority: P3
> Labels: Clarified, portability
> Fix For: 2.25.0
>
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
> There are multiple benefits including optimized String representation in
> memory, better GC, more Docker friendliness and others that could be of the
> interest of users.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
