[
https://issues.apache.org/jira/browse/BEAM-6540?focusedWorklogId=194841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194841
]
ASF GitHub Bot logged work on BEAM-6540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/19 22:24
Start Date: 05/Feb/19 22:24
Worklog Time Spent: 10m
Work Description: drieber commented on pull request #7664: [BEAM-6540]
Windmill quota piping
URL: https://github.com/apache/beam/pull/7664#discussion_r254069605
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -1416,4 +1458,62 @@ public void close() throws IOException {
stream.close();
}
}
+
+ /**
+ * A stopwatch used to track the amount of time spent throttled due to
Resource Exhausted errors.
+ * Throttle time is cumulative for all three rpcs types but not for all
streams. So if GetWork and
+ * CommitWork are both blocked for x, totalTime will be 2x. However, if 2
GetWork streams are both
+ * blocked for x totalTime will be x. All methods are thread safe.
+ */
+ private static class ThrottleTimer {
+
+ // This is -1 if not currently being throttled or the time in
+ // milliseconds when throttling for this type started.
+ private Long startTime = Long.valueOf(-1);
Review comment:
If you are going to use -1 or actual value, then this can be primitive long.
You could use NULL instead of -1 to signal "not throttled". Up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 194841)
Time Spent: 5.5h (was: 5h 20m)
> Autoscaling should be aware of Streaming RPC Quota
> ---------------------------------------------------
>
> Key: BEAM-6540
> URL: https://issues.apache.org/jira/browse/BEAM-6540
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Affects Versions: 2.11.0
> Reporter: Dustin Rhodes
> Assignee: Tyler Akidau
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Streaming Windmill Service introduces quota for the shared windmill workers.
> Autoscaling needs to be aware of throttling due to this quota in order to not
> upscale. This PR adds in that reporting.
>
> It also introduces the flag --EnableStreamingEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
