[
https://issues.apache.org/jira/browse/BEAM-11272?focusedWorklogId=540726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540726
]
ASF GitHub Bot logged work on BEAM-11272:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/21 14:03
Start Date: 24/Jan/21 14:03
Worklog Time Spent: 10m
Work Description: rgruener commented on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-766353199
> PTransform is a base class for many, many other ptransforms. I'm worried
about potential side effects if you decide to remove that. Also, this pull
request is focused on combiners, so let's stick to this.
Makes sense. I think this should be ready for review in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 540726)
Time Spent: 3h 40m (was: 3.5h)
> Combiner Label Constructor Arg Not Passed Through To pTransform
> ---------------------------------------------------------------
>
> Key: BEAM-11272
> URL: https://issues.apache.org/jira/browse/BEAM-11272
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robbie Gruener
> Priority: P3
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The combiners ToSet, ToDict, and ToList have a label argument in their
> constructor:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/combiners.py#L877]
>
> However the label passed through to the parent class is not actually used
> (there is a mismatch in the super constructor)
> https://github.com/apache/beam/blob/7ac82a875462f2c2570a1157b782ebadddebbe70/sdks/python/apache_beam/transforms/combiners.py#L68
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
