[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=540968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540968
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/21 09:23
Start Date: 25/Jan/21 09:23
Worklog Time Spent: 10m
Work Description: sonam-vend commented on a change in pull request #13651:
URL: https://github.com/apache/beam/pull/13651#discussion_r563548926
##########
File path: model/fn-execution/build.gradle
##########
@@ -17,17 +17,16 @@
*/
plugins { id 'org.apache.beam.module' }
-applyPortabilityNature(
+/*applyPortabilityNature(
automaticModuleName: 'org.apache.beam.model.fn.execution',
shadowJarValidationExcludes: ["org/apache/beam/model/fnexecution/v1/**"]
+)*/
+
+applyJavaNature(
+ enableStrictDependencies: true,
Review comment:
Since applyJavaNature was not declared here before, i had to explicitly
create it. I copied the contents of applyPortabilityNature to applyJavaNature
and too set enableStrictDependencies: true.
@ibzib can you please validate if it is a valid approach.
cc @shehzaadn-vd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 540968)
Time Spent: 87.5h (was: 87h 20m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 87.5h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
