[ 
https://issues.apache.org/jira/browse/BEAM-9541?focusedWorklogId=542363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542363
 ]

ASF GitHub Bot logged work on BEAM-9541:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/21 19:33
            Start Date: 26/Jan/21 19:33
    Worklog Time Spent: 10m 
      Work Description: ibzib commented on pull request #13798:
URL: https://github.com/apache/beam/pull/13798#issuecomment-767777390


   > LGTM! I think my same concern is if someone accidently cleans up a docker 
image, or if someone has locally tested a new version of $LANG that is tagged 
at a specific release RC, but both seem very unlikely. I would feel more 
confident if there was a list of images to at least compare against, but that 
does also involve hardcoding the image names/versions again.
   
   Another solution I considered is using [docker 
search](https://docs.docker.com/engine/reference/commandline/search/) to list 
the images that have been uploaded to Docker Hub. Unfortunately the docker 
search tool does not offer the functionality to do this (it can find repos, but 
not list tags, for example). We could alternatively curl and parse a json blob 
from docker hub's API endpoint, but that seems like overkill here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 542363)
    Time Spent: 10h 40m  (was: 10.5h)

> Single source of truth for supported Flink versions
> ---------------------------------------------------
>
>                 Key: BEAM-9541
>                 URL: https://issues.apache.org/jira/browse/BEAM-9541
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Kyle Weaver
>            Assignee: Kyle Weaver
>            Priority: P2
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> Currently, there is a large number of hard-coded references to the supported 
> Flink versions (either the newest version, or a list of all supported 
> versions). These should be condensed to a single source of truth to make 
> upgrades easier and more robust.
> Previously, we awked the list of Flink subdirectories, but this is not 
> reliable because old, unsupported Flink versions can leave build directories 
> behind. It would be better to read versions from a handwritten file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to