[
https://issues.apache.org/jira/browse/BEAM-9541?focusedWorklogId=542408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542408
]
ASF GitHub Bot logged work on BEAM-9541:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 20:51
Start Date: 26/Jan/21 20:51
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #13809:
URL: https://github.com/apache/beam/pull/13809#issuecomment-767819689
> LGTM, though I'm less inclined to have this read from gradle.properties
like a text file vs just having another hardcoded list. I think hardcoded list
is more readable for what I think is not too much more hassle when updating the
flink versions, but then again I do not actually update the flink versions :)
Yeah, I might have gone overboard with the "single source of truth" thing.
But every time we upgrade Flink versions we forget places and it causes weird
bugs and user confusion.
FWIW I think the real readability issue here is that this logic is written
in bash. If we had a gradle task to push all Flink containers, things would be
much simpler. Maybe I'll do that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542408)
Time Spent: 13h 20m (was: 13h 10m)
> Single source of truth for supported Flink versions
> ---------------------------------------------------
>
> Key: BEAM-9541
> URL: https://issues.apache.org/jira/browse/BEAM-9541
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> Currently, there is a large number of hard-coded references to the supported
> Flink versions (either the newest version, or a list of all supported
> versions). These should be condensed to a single source of truth to make
> upgrades easier and more robust.
> Previously, we awked the list of Flink subdirectories, but this is not
> reliable because old, unsupported Flink versions can leave build directories
> behind. It would be better to read versions from a handwritten file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
