[
https://issues.apache.org/jira/browse/BEAM-11688?focusedWorklogId=542545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542545
]
ASF GitHub Bot logged work on BEAM-11688:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 01:11
Start Date: 27/Jan/21 01:11
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #13812:
URL: https://github.com/apache/beam/pull/13812#discussion_r564949112
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -336,18 +336,18 @@ def __init__(self, proto_message_type):
self.proto_message_type = proto_message_type
def encode(self, value):
- return value.SerializeToString()
+ return value.SerializePartialToString()
def decode(self, encoded):
proto_message = self.proto_message_type()
- proto_message.ParseFromString(encoded)
+ proto_message.ParseFromString(encoded) # This is in effect "ParsePartial".
Review comment:
This comment is saying that this method can parse both initialized and
partial messages. (there is no ParsePartialFromString)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542545)
Time Spent: 1.5h (was: 1h 20m)
> Python ProtoCoder: support partial messages
> -------------------------------------------
>
> Key: BEAM-11688
> URL: https://issues.apache.org/jira/browse/BEAM-11688
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The current implementation requires fully initialized messages. Using
> SerializePartialToString will relax this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
