[
https://issues.apache.org/jira/browse/BEAM-11165?focusedWorklogId=543097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543097
]
ASF GitHub Bot logged work on BEAM-11165:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 21:32
Start Date: 27/Jan/21 21:32
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #13759:
URL: https://github.com/apache/beam/pull/13759#discussion_r565648828
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java
##########
@@ -191,27 +212,96 @@ public void setup() {
stream = exp.stream();
}
+ @StartBundle
+ public void startBundle() {
+ pending = new HashMap<>();
+ previousRow = null;
+ previousFuture = null;
+ }
+
+ @Override
+ public Duration getAllowedTimestampSkew() {
+ return Duration.millis(Long.MAX_VALUE);
+ }
+
@ProcessElement
- public void processElement(ProcessContext c) throws InterruptedException {
- Map<String, Value> columns = new HashMap<>();
- Row row = c.element();
- for (int i : referencedColumns) {
- columns.put(
- columnName(i),
- ZetaSqlBeamTranslationUtils.toZetaSqlValue(
- row.getBaseValue(i, Object.class),
inputSchema.getField(i).getType()));
+ public void processElement(
+ @Element Row row, @Timestamp Instant t, BoundedWindow w,
OutputReceiver<Row> r)
+ throws InterruptedException {
+ final Future<Value> vf;
Review comment:
how about `valueFuture`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543097)
Time Spent: 4h 10m (was: 4h)
> Use new ZetaSQL PreparedExpression features in ZetaSQL Calc
> -----------------------------------------------------------
>
> Key: BEAM-11165
> URL: https://issues.apache.org/jira/browse/BEAM-11165
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Priority: P2
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> The latest release of ZetaSQL has a streaming evaluation API and exposes the
> set of columns referenced in the evaluator. Both of these features could be
> used by ZetaSQL Calc for a large performance gain.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
